fix: pass empty object to headers initializer to prevent crash on chrome 49 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
approved these changes
Apr 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 86.26% 86.29% +0.03%
==========================================
Files 5 5
Lines 415 416 +1
Branches 68 69 +1
==========================================
+ Hits 358 359 +1
Misses 57 57
|
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofetch crashes in Chrome 49 (which is the latest available Chrome on Windows XP which is still relevant in certain GovTech) with this message:
This is because older Chrome didn't treat
new Headers(undefined)asnew Headers().This PR fixes this inconvenience with no noticeable burden for modern browsers (or code base readability).
Related: whatwg/fetch#185