Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix the default export module in CJS, close #123 #124

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

markthree
Copy link
Contributor

πŸ”— Linked issue

#123

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@harlan-zw harlan-zw requested a review from pi0 January 20, 2024 12:52
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (2803fd7) 57.90% compared to head (767da4c) 57.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   57.90%   57.90%           
=======================================
  Files          18       18           
  Lines        1872     1872           
  Branches      284      284           
=======================================
  Hits         1084     1084           
  Misses        779      779           
  Partials        9        9           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@harlan-zw
Copy link
Contributor

harlan-zw commented Jan 20, 2024

LGTM will wait for someone else to review though

@manniL
Copy link
Member

manniL commented Jan 20, 2024

LGTM to me too πŸ‘

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❀️

@pi0 pi0 merged commit 81c7f61 into unjs:main Jan 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants