Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in GenerateTypesOptions #81

Merged
merged 2 commits into from
Mar 27, 2023
Merged

fix: correct typo in GenerateTypesOptions #81

merged 2 commits into from
Mar 27, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A small typo. I've added a normalization step to ensure this isn't a breaking change.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 27, 2023
@danielroe danielroe requested a review from pi0 March 27, 2023 09:54
@danielroe danielroe self-assigned this Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #81 (4fcb045) into main (b4c13a3) will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   87.76%   87.81%   +0.04%     
==========================================
  Files           8        8              
  Lines        1112     1116       +4     
  Branches      283      283              
==========================================
+ Hits          976      980       +4     
  Misses        136      136              
Impacted Files Coverage Ξ”
src/generator/dts.ts 93.11% <85.71%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@pi0 pi0 merged commit 4b4e28c into main Mar 27, 2023
@pi0 pi0 deleted the fix/typo branch March 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants