Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Windows target should include both packages and unpackaged opt… #1080

Conversation

aesteves900
Copy link
Contributor

…ions add add PublishTrimmed on publish file

GitHub Issue (If applicable): #1037

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@aesteves900
Copy link
Contributor Author

@nickrandolph , The issue mentioned in the publish file microsoft/CsWinRT#373 was closed on git. I tested x86 and x64 publish profiles when PublishTrimmed is true with success. I cannot test arm publish profile because I have no hardware that matches with this platform.

@aesteves900
Copy link
Contributor Author

I tried all of the possible variations on the TrimMode, but failing the build on CI, I reverted the changes and kept just the first request. about unpack on launchsettings.json, @nickrandolph let me know if you want me to keep trie to figure out this scenario.

@aesteves900 aesteves900 marked this pull request as ready for review January 18, 2023 13:56
@nickrandolph nickrandolph merged commit ae7b2b9 into unoplatform:main Jan 18, 2023
@aesteves900 aesteves900 deleted the dev/AEST/1037-template-win-include-both-packages branch January 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants