fix: remove nav bar back icon, use symbol/path for non-win/non-mobile #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @jeromelaban / @nickrandolph / @dansiegel |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-860.eastus2.azurestaticapps.net |
Xiaoy312
approved these changes
Sep 29, 2023
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-860.eastus2.azurestaticapps.net |
10 tasks
|
@Mergifyio backport legacy/3x |
✅ Backports have been created
|
kazo0
added a commit
that referenced
this pull request
Oct 25, 2023
… (backport #860) (#861) Co-authored-by: Steve Bilogan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #658
Removed the BackIcon.png and MaterialBackIcon.png assets as they are no longer needed.
Uses a SymbolIcon/PathIcon for the default back button on non-windows and non-mobile platforms.
For mobile platforms: the default native back icon is used
For Windows: we cannot reuse an IconElement within a staticresource like a style (see microsoft/microsoft-ui-xaml#1494)