fix(binding): Avoid reading source property on UpdateSource for non-DP #13698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpinedam
approved these changes
Sep 20, 2023
ajpinedam
changed the title
|
The build 94711 found UI Test snapshots differences: Details
|
Youssef1313
reviewed
Sep 20, 2023
Youssef1313
reviewed
Sep 20, 2023
Youssef1313
approved these changes
Sep 20, 2023
|
The build 94783 found UI Test snapshots differences: Details
|
|
@Mergifyio backport release/stable/4.9 release/stable/4.10 legacy/4x |
✅ Backports have been created
|
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #11956
PR Type
What kind of change does this PR introduce?
What is the new behavior?
During a two-way binding, the source bound property will not be read before being set. This will avoid scenarios during datacontext reset that may read properties for out of date instances.
Copilot Summary
🤖 Generated by Copilot at 203609d
This pull request enhances the data binding system and the
ComboBoxcontrol in Uno.UI. It adds a new unit test forComboBox, refactors theBindingItemclass to use flags and support a new scenario, fixes a data binding bug in theBindingPathclass, and improves the performance and memory usage of the binding system.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):