feat(textbox): skia textbox implementation #13901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/skia ✏️
Youssef1313
reviewed
Oct 9, 2023
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Oct 9, 2023
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Oct 9, 2023
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.cs
Outdated
Show resolved
Hide resolved
ramezgerges
force-pushed
the
skia_textbox_impl
branch
from
bbb5dad
to
2e4131e
Compare
|
Triple tapping is currently blocked by #13936 |
jeromelaban
reviewed
Oct 12, 2023
6 tasks
ramezgerges
changed the title
github-actions
bot
added
the
area/automation
ramezgerges
force-pushed
the
skia_textbox_impl
branch
2 times, most recently
from
5b5104e
to
bbdd9be
Compare
ramezgerges
force-pushed
the
skia_textbox_impl
branch
3 times, most recently
from
4dd1ac5
to
5bcba64
Compare
Youssef1313
reviewed
Nov 3, 2023
ramezgerges
force-pushed
the
skia_textbox_impl
branch
from
cf381d0
to
8761d1a
Compare
jeromelaban
reviewed
Nov 3, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jeromelaban
approved these changes
Nov 6, 2023
github-actions
bot
added
the
platform/wasm 🌐
ramezgerges
force-pushed
the
skia_textbox_impl
branch
2 times, most recently
from
21869f4
to
0a929c1
Compare
jeromelaban
reviewed
Nov 7, 2023
…kia and various fixes
ramezgerges
force-pushed
the
skia_textbox_impl
branch
from
0a929c1
to
906ee9a
Compare
Youssef1313
reviewed
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #9417
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at acf7c2e
This pull request adds support for Unicode characters in key events on the Skia platform, by using platform-specific APIs to map keycodes to Unicode and adding a new
UnicodeKeyproperty to theKeyRoutedEventArgsandKeyEventArgsclasses. It also adds a feature flag to allow switching between using a native overlay or a skia-based implementation for theTextBoxcontrol on the Skia platform, and fixes some layout, selection, and hyperlink issues for theTextBlockandTextBoxcontrols.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):