Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore XamlReader HR for mobile targets #14105

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

jeromelaban
Copy link
Member

@jeromelaban jeromelaban commented Oct 25, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Restores XamlReader HR for mobile targets until dotnet/runtime#93860 is fixed.

Copilot Summary

🤖 Generated by Copilot at e68d4f9

This pull request adds support for different hot reload modes for the Uno Platform, which enable faster and more flexible development workflows. It introduces the UnoHotReloadMode MSBuild property, which allows the user to choose the preferred mode, and the HotReloadMode enum, which defines the possible values. It also refactors and improves the ClientHotReloadProcessor class, which handles the hot reload logic for different modes, and adds some common methods and types to the ClientHotReloadProcessor.Common.cs file. It also comments out some sections of the global.json file to avoid conflicts with the .NET 6 SDK.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Oct 25, 2023
@jeromelaban jeromelaban force-pushed the dev/jela/hr-xamlreader branch 2 times, most recently from 8cebc89 to 45413ab Compare October 25, 2023 19:33
@nventive-devops
Copy link
Contributor

The build 99121 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 63, ios: 57, ios-Snap: 643, skia-gtk-screenshots: 22, skia-wpf-screenshots: 18, wasm: 30, wasm-automated-net7.0-UWP-Benchmarks: 0, wasm-automated-net7.0-UWP-Default: 32, wasm-automated-net7.0-UWP-RuntimeTests: 1, wasm-automated-net7.0-WinUI-RuntimeTests: 0

Details
  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 63 changed over 1048

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_Click_Focus_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_Click_Focus
    • ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled
    • ListView_ListView_OwnContainer_Virtualized_UITests_Shared_Windows_UI_Xaml_Controls_ListView_OwnContainer_Virtualized
    • ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
    • Control_BasicEnability_UITests_Shared_Windows_UI_Xaml_Enability_BasicEnability
    • MUX_MUXControlsTestApp_RefreshContainerPage_MUXControlsTestApp_RefreshContainerPage
    • Scrolling_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_Remove_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_Remove
    • TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
    • Transform_Border_With_TranslateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Border_With_TranslateTransform
    • Transform_Image_With_RotateTransform_Uno_UI_Samples_Content_UITests_Transform_Image_With_RotateTransform
    • ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
  • ios: 57 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • FocusManager_FocusDirection_Down_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Initial_State
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Collapsed_State
    • ListView_ExpandableItem_ExpandSingleItem_Collapsed_State
    • ListView_ExpandableItem_ExpandSingleItem_Initial_State
    • ListView_ObservableCollection_Creation_Count_Scrolled2
    • ListView_VirtualizePanelAdaptaterIdCache_ListView_VirtualizePanelAdaptaterIdCache
    • ListView_VirtualizePanelAdaptaterIdCache_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_VirtualizePanelAdaptaterIdCache
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
  • ios-Snap: 643 changed over 1039

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_AutoBorderStretchwithleftmargin_Uno_UI_Samples_UITests_BorderTestsControl_AutoBorderStretchwithleftmargin
    • Border_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlap
    • Border_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness
    • Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
    • Brushes_RectanglemaskingRectangleGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_RectanglemaskingRectangleGrid
    • ContentControl_ContentControl_SelectorInheritance_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_SelectorInheritance
    • ContentControl_ContentControl_SetNull_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_SetNull
    • Default_UITests_Toolkit_ElevatedView_Corners_UITests_Toolkit_ElevatedView_Corners
    • Default_UITests_Toolkit_ElevatedView_Dimensions_UITests_Toolkit_ElevatedView_Dimensions
    • FlipView_FlipView_Images_UITests_Windows_UI_Xaml_Controls_FlipView_FlipView_Images
    • Flyouts_Flyout_Attached_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Attached
    • Flyouts_UITests_Windows_UI_Xaml_Controls_MenuFlyoutTests_MenuFlyout_Nested_5639_UITests_Windows_UI_Xaml_Controls_MenuFlyoutTests_MenuFlyout_Nested_5639
    • Flyouts_Vanilla_UITests_Shared_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_Vanilla
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageAlignment2541
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
    • ListView_ListView_Expandable_Item_Large_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_ListView_Expandable_Item_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item
    • ListView_ListView_FirstLastCacheIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_FirstLastCacheIndex
  • skia-gtk-screenshots: 22 changed over 1136

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes-ImageBrush_SameWithDelay.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Image-ImageSourceStream.png
    • MediaPlayerElement-Using .3gp.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • NavigationView-NavigationViewRS4Page.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • TextBlock-TextBlockMultilineInStarStackPanel.png
    • PipsPager-PipsPagerExamples.png
    • Image-UniformToFill100x100.png
    • Progress-WinUIProgressRing_Features.png
    • ListView-ListViewSelectedItems.png
    • Windows.Graphics.Display-DisplayInformation.png
    • MediaPlayerElement-MediaPlayerElement_Stretch_Fill.png
    • WinUI-PipsPagerExamples.png
    • Windows.UI.Composition-RedirectVisual.png
    • Windows.UI.Composition-CompositionMaskBrush.png
  • skia-wpf-screenshots: 18 changed over 1136

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image-Image_Stretch.png
    • Brushes-ImageBrushChangingCornerRadius.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Image-UniformToFill100x100.png
    • PipsPager-PipsPagerExamples.png
    • DragAndDrop-DragDrop_TestPage.png
    • Progress-WindowsProgressRing_GH1220.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • MediaPlayerElement-Mini player.png
    • Progress-ProgressRingHeightTest.png
    • Transform-TransformToVisual_Translate2d.png
    • Windows.UI.Composition-CompositionMaskBrush.png
    • Windows.UI.Composition-CompositionVisualSurface.png
    • Windows.UI.Composition-RedirectVisual.png
    • WinUI-PipsPagerExamples.png
  • wasm: 30 changed over 1044

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_Fill
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.ProgressRingHeightTest
    • UITests.Windows_UI_Xaml_Shapes.PathStretchModes
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage
    • MUXControlsTestApp.NavigationViewRS4Page
    • UITests.Windows_UI_ViewManagement.ApplicationViewSizing
    • initial_state
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • MUXControlsTestApp.PipsPagerExamples
    • Uno.UI.Samples.Content.UITests.CommandBar.CommandBar_With_Long_Sentences
    • SamplesApp.Samples.NavigationViewSample.NavigationViewSample
    • UITests.Windows_Media.MediaPlayerTests
    • MUXControlsTestApp.NavigationViewStretchPage
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_Extension
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
  • wasm-automated-net7.0-UWP-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-UWP-Default: 32 changed over 1937

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
    • MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension
    • MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ScrollBar_Vertical_initial_indicators
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
  • wasm-automated-net7.0-UWP-RuntimeTests: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage
  • wasm-automated-net7.0-WinUI-RuntimeTests: 0 changed over 1

@jeromelaban jeromelaban marked this pull request as ready for review October 26, 2023 12:07
@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.0

@mergify
Copy link
Contributor

mergify bot commented Oct 26, 2023

backport release/stable/5.0

✅ Backports have been created

@nventive-devops
Copy link
Contributor

The build 99306 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 50, ios: 169, ios-Snap: 606, skia-gtk-screenshots: 24, skia-wpf-screenshots: 16, wasm: 28, wasm-automated-net7.0-UWP-Benchmarks: 0, wasm-automated-net7.0-UWP-Default: 35, wasm-automated-net7.0-UWP-RuntimeTests: 0, wasm-automated-net7.0-WinUI-RuntimeTests: 0

Details
  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 50 changed over 1048

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarPage_UITests_Microsoft_UI_Xaml_Controls_ProgressBar_WinUIProgressBarPage
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • PagerControl_UITests_Microsoft_UI_Xaml_Controls_PagerControlTests_PagerControlPage_UITests_Microsoft_UI_Xaml_Controls_PagerControlTests_PagerControlPage
    • TextBox_TextBox_Padding_In_ScrollViewer_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Padding_In_ScrollViewer
    • Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • Flyouts_Flyout_Unloaded_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Unloaded
    • FrameworkElement_UITests_Windows_UI_Xaml_FrameworkElementTests_DynamicBackgroundSizing_UITests_Windows_UI_Xaml_FrameworkElementTests_DynamicBackgroundSizing
    • Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
    • Grid_CenteredGridinGridwithtwofixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwithtwofixedsizechildren
    • ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
    • TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
    • Transform_Border_With_RotateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Border_With_RotateTransform
    • Transform_Border_With_TranslateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Border_With_TranslateTransform
    • Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
    • FrameworkElement_XamlEvent_Leak_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_XamlEvent_Leak
    • Grid_Quadrant_uneven_split_Uno_UI_Samples_Content_UITests_GridTestsControl_Quadrant_uneven_split
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
    • ListView_ListView_Selection_Events_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Events
  • ios: 169 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_Collapsed_State
    • ListView_ExpandableItem_ExpandMultipleItems_Collapsed_State
    • ListView_ExpandableItem_ExpandMultipleItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item
    • ListView_ExpandableItem_ExpandMultipleItems_Expanded_State
    • ListView_Selection_Events_Ordering_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Events
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_ObservableCollection_Creation_Count_Added
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large
    • ListView_ObservableCollection_Creation_Count_UITests_Windows_UI_Xaml_Controls_ListView_ListView_ObservableCollection_CreationCount
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ListViewItem_Click_Focus_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_Click_Focus
    • ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_Expanded_State
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_Expanded_State
    • ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • ListView_ObservableCollection_Creation_Count_Scrolled2
    • ListView_Weird_Measure_During_Arrange_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Weird_Measure
    • ListView_ExpandableItemLarge_ExpandHeader_Validation_Initial_State
    • ListView_ObservableCollection_Creation_Count_Scrolled1
  • ios-Snap: 606 changed over 1039

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_Brushes_ImplicitConvert_UITests_Windows_UI_Xaml_Media_BrushesTests_Brushes_ImplicitConvert
    • Buttons_Buttons_Native_UITests_Shared_Windows_UI_Xaml_Controls_Buttons_Native
    • Buttons_HyperlinkButton_IsEnabled_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_HyperlinkButton_IsEnabled_Automated
    • Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage
    • CheckBox_UITests_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_States_UITests_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_States
    • Clipping_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingWithOpacity_UITests_Shared_Windows_UI_Xaml_Clipping_ClippingWithOpacity
    • ComboBox_ComboBox_Legacy_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Legacy
    • ComboBox_ComboBox_MaxDropdownHeight_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_MaxDropdownHeight
    • Gesture_Recognizer_VisualStates_Buttons_UITests_Shared_Windows_UI_Input_VisualStatesTests_Buttons
    • Gesture_Recognizer_VisualStates_ComboBoxItem_UITests_Shared_Windows_UI_Input_VisualStatesTests_ComboBoxItem
    • Grid_Grid_Two_bottom_row_Auto_middle_col_auto_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_Two_bottom_row_Auto_middle_col_auto
    • Grid_Grid_with_attributed_string_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_attributed_string
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
    • ListView_ListView_ItemsPanel_HotSwap_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ItemsPanel_HotSwap
    • ListView_ListView_OwnContainer_Virtualized_UITests_Shared_Windows_UI_Xaml_Controls_ListView_OwnContainer_Virtualized
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • MenuBar_SimpleMenuBar_UITests_Shared_Windows_UI_Xaml_Controls_MenuBarTests_SimpleMenuBar
    • NavigationView_MUXControlsTestApp_NavigationViewTopNavOverflowButtonPage_MUXControlsTestApp_NavigationViewTopNavOverflowButtonPage
    • NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
    • TextBlock_ForcedTextWithCarriageReturn_MaxLines_One_Uno_UI_Samples_Content_UITests_TextBlockControl_ForcedTextWithCarriageReturn_MaxLines_One
  • skia-gtk-screenshots: 24 changed over 1136

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes-ImageBrush_SameWithDelay.png
    • ListView-ListViewSelectedItems.png
    • MUX-NavigationViewRS4Page.png
    • Progress-ProgressRingHeightTest.png
    • Brushes-DoubleImageBrushInList.png
    • Progress-WindowsProgressRing_GH1220.png
    • Brushes-BorderImageBrush.png
    • NavigationView-NavigationViewRS4Page.png
    • MediaPlayerElement-Mini player.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Pickers-CalendarView_Theming.png
    • TextBlock-TextBlockMultilineInStarStackPanel.png
    • Image-ImageSourceStream.png
    • PipsPager-PipsPagerExamples.png
    • MUX-TabViewPage.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Windows.Graphics.Display-DisplayInformation.png
  • skia-wpf-screenshots: 16 changed over 1136

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation-AutomationProperties_Name.png
    • ListView-ListViewSelectedItems.png
    • Pickers-CalendarView_Theming.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Progress-WindowsProgressRing_GH1220.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • PipsPager-PipsPagerExamples.png
    • TabView-TabViewPage.png
    • Progress-ProgressRingHeightTest.png
    • WinUI-PipsPagerExamples.png
    • Windows.UI.Composition-CompositionMaskBrush.png
    • Windows.UI.Composition-CompositionVisualSurface.png
    • Windows.UI.Composition-RedirectVisual.png
  • wasm: 28 changed over 1044

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • MUXControlsTestApp.PipsPagerExamples
    • UITests.Windows_Media.MediaPlayerTests
    • MUXControlsTestApp.NavigationViewTopNavPage
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_Features
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Ogg_Extension
    • UITests.Uno_Web.Http.CookieManagerTests
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_Fill
    • initial_state
    • MUXControlsTestApp.SwipeControlPage2
    • UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage
    • UITests.Windows_UI_Xaml_Controls.CalendarView.CalendarView_Theming
    • UITests.Windows_UI_Xaml_Controls.ProgressRing.WindowsProgressRing_GH1220
    • SamplesApp.Samples.Microsoft_UI_Xaml_Controls.NavigationViewTests.FluentStyle.FluentStyle_NavigationViewSample
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
  • wasm-automated-net7.0-UWP-Benchmarks: 0 changed over 1

  • wasm-automated-net7.0-UWP-Default: 35 changed over 1937

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension
    • MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension
    • MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
    • MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_ProgressRingHeightTest
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRingPage
  • wasm-automated-net7.0-UWP-RuntimeTests: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests: 0 changed over 1

@jeromelaban jeromelaban merged commit fecdbb9 into master Oct 27, 2023
85 checks passed
@jeromelaban jeromelaban deleted the dev/jela/hr-xamlreader branch October 27, 2023 12:20
jeromelaban added a commit that referenced this pull request Oct 27, 2023
…5.0/pr-14105

fix: Restore XamlReader HR for mobile targets (backport #14105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants