Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Add Sample Test for Expander header bindings #17895

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Test: Add Sample Test for Expander header bindings #17895

wants to merge 3 commits into from

Conversation

ajpinedam
Copy link
Contributor

@ajpinedam ajpinedam commented Aug 9, 2024 •
edited
Loading

GitHub Issue (If applicable):

related #17312

PR Type

What kind of change does this PR introduce?

  • Other... Please describe:

What is the current behavior?

What is the new behavior?

This PR adds a sample to the Sample App to reproduce the error reported on #17312. This will help validate whether the Fix being worked on in PR #17645 does indeed fix the problem.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Aug 9, 2024
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Aug 9, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17895/index.html

@ajpinedam ajpinedam marked this pull request as ready for review August 22, 2024 02:32
@ajpinedam ajpinedam changed the title fix Expander header bindings Test: Add Sample Test for Expander header bindings Aug 22, 2024
@ajpinedam ajpinedam force-pushed the fix/expander.header.bindings branch 2 times, most recently from 5f80ddd to 22a0b34 Compare September 8, 2024 14:39
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17895/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17895/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17895/index.html

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Xiaoy312
Xiaoy312 reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why manual test when you can do runtime test?
which we already have in the templated-parent branch:
https://github.com/unoplatform/uno/blob/dev/xygu/20240703/templated-parent-rework-v3/src/Uno.UI.RuntimeTests/Tests/TemplatedParent/TemplatedParentTests.cs#L111

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17895/index.html

@ajpinedam
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 left review comments

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@ajpinedam ajpinedam

Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajpinedam @unodevops @MartinZikmund @Xiaoy312 @jeromelaban