Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IsPropMethodCall DPs #18101

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 2, 2024

GitHub Issue (If applicable): closes #17300

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18101/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18101/index.html

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Sep 3, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18101/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18101/index.html

@Youssef1313 Youssef1313 force-pushed the ispropmethodcall branch 2 times, most recently from 12f8fa1 to fb2a408 Compare September 10, 2024 17:38
@Youssef1313
Copy link
Member Author

This is green already, but one needed enhancement first is to avoid using DependencyPropertyDetails for IsPropMethodCall DPs as the value is already stored in the DependencyObject itself.

We need to have some sort of abstraction here for DependencyPropertyDetails, and have a "light-weight" version of it that only stores the precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement IsPropMethodCall DP flag
2 participants