-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Platform runtime helper #18758
base: master
Are you sure you want to change the base?
Conversation
SkiaGtk, | ||
SkiaWpf, | ||
SkiaX11, | ||
SkiaFrameBuffer, | ||
SkiaMacOS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SkiaIslands?
SkiaWpf, | ||
SkiaX11, | ||
SkiaFrameBuffer, | ||
SkiaMacOS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When\where\how would Skia*
(e.g. SkiaMacOS
) be returned ?
There's no code to allow to set it (from the host) since it's returned from a method. An internal Set...
method (only for __SKIA__
could be used by the different hosts).
Also if Skia*
values are returned when would the lone Skia
value be returned ?
You might want to add an extension method, on the enum, like IsSkia()
to make it easier to detect all Skia-based platforms (and remove Skia
).
Co-authored-by: Jérôme Laban <[email protected]>
… into platform-runtime-helper
GitHub Issue (If applicable): closes #11545
PR Type
What kind of change does this PR introduce?
What is the current behavior?
You have to use conditionals to knot the current platform runtime.
What is the new behavior?
You can use RuntimeHelper.CurrentPlatform enumeration.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Follow this conversation:
#18432 (reply in thread)
I've had some issues with the filtered solutions, I've had been able to test it in Skia only.
Please, someone else should check the other platforms.
Internal Issue (If applicable):
#11545