fix: Use SymbolThemeFontFamily instead of hard-coded Segoe MDL2 Assets #6924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robloo
reviewed
Sep 1, 2021
src/Uno.UI.FluentTheme/Resources/Priority02/MenuFlyout_themeresources.xaml
Outdated
Show resolved
Hide resolved
Youssef1313
force-pushed
the
issues/6638
branch
3 times, most recently
from
de1bb9f
to
7c23d9a
Compare
Youssef1313
force-pushed
the
issues/6638
branch
from
7c23d9a
to
9dae693
Compare
davidjohnoliver
approved these changes
Sep 1, 2021
src/Uno.UI.FluentTheme/Resources/Priority02/MenuFlyout_themeresources.xaml
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/SplitButton/SplitButtonTests.cs
Show resolved
Hide resolved
|
@davidjohnoliver The upstream has already this fix. I probably should have imported everything to get any potential other fixes, but I kept it simple and more focused on the linked issue. |
jeromelaban
approved these changes
Sep 1, 2021
Great! Ignore my comment about adding 'Uno workaround' comments then. |
ajpinedam
approved these changes
Sep 1, 2021
|
Here is the upstream PR, FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #6638
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Chevron glyph doesn't show correctly when using fluent theme.
What is the new behavior?
Shows correctly.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):