Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add style to work with v-calendar time picker (#243) #265

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

valh1996
Copy link
Contributor

@valh1996 valh1996 commented Jan 11, 2024

close #243

Dark
CleanShot 2024-01-11 at 22 04 23

Light
CleanShot 2024-01-11 at 22 05 15

@sadeghbarati
Copy link
Collaborator

Wow, Thanks for your time ❤️

@sadeghbarati
Copy link
Collaborator

Can you also add examples to the doc?

like DatepickerWithTimePickerDemo.vue

@valh1996
Copy link
Contributor Author

Can you also add examples to the doc?

like DatepickerWithTimePickerDemo.vue

Done 👍

@sadeghbarati
Copy link
Collaborator

Please, also run

pnpm build:registry

in apps/www

@valh1996
Copy link
Contributor Author

Please, also run

pnpm build:registry

in apps/www

oh sorry, I didn't know!

@sadeghbarati

This comment was marked as resolved.

@sadeghbarati sadeghbarati merged commit dfbb738 into unovue:dev Jan 11, 2024
1 check failed
@hrynevychroman
Copy link
Collaborator

@valh1996 Fireeee 🔥 👍

@valh1996
Copy link
Contributor Author

image

Sry :D

can you add a little bit of space between separator and dates

Thanks ❤️

@@ -267,7 +267,7 @@ onMounted(async () => {
@apply mr-1 text-primary stroke-primary;
}
.vc-time-select-group select {
@apply bg-transparent p-1 appearance-none outline-none text-center;
@apply bg-primary-foreground p-1 appearance-none outline-none text-center;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadeghbarati The problem is that by doing bg-primary-foreground instead of transparent, it broke the edges:
CleanShot 2024-01-12 at 17 40 07@2x

@valh1996 valh1996 deleted the feature/calendar-time-styles branch January 17, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add style to work with v-calendar time picker
3 participants