Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio group indicator fill #280

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Conversation

antonreshetov
Copy link
Contributor

No description provided.

@antonreshetov
Copy link
Contributor Author

It seems like it's not working.

image

https://www.shadcn-vue.com/docs/components/radio-group

@MuhammadM1998
Copy link
Contributor

MuhammadM1998 commented Jan 16, 2024

In shadcn it applies color to background using fill-current and to text using text-current

<Circle className="h-2.5 w-2.5 fill-current text-current" />

In shadcn-vue, it only applies the color to text using text-foreground and not the background, which this PR fixes

<Circle class="w-2.5 h-2.5 text-foreground" /> <!-- No equivalent class to `fill-current` -->

Copy link

github-actions bot commented Jan 17, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: 513af8cd
Status: ⚡️ Deployment in progress...
Preview URL: https://e1bbfeb7.shadcn-vue.pages.dev
Branch Preview URL: https://e1bbfeb7.shadcn-vue.pages.dev

@zernonia zernonia merged commit 7727c72 into unovue:dev Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants