Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide navigation in "time" mode #283

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

valh1996
Copy link
Contributor

@valh1996 valh1996 commented Jan 17, 2024

This PR will hide navigation buttons in time mode (not date).

For more complex needs, it may be useful to use the Calendar component in time only mode. In particular, to be able to customize the appearance more easily, example :

<Calendar 
  type="range"
  v-model.range="form.date.range" 
  mode="date" 
  :columns="2"
>
<template #footer>
  <div class="w-full">
    Entry time:
    <Calendar 
      v-model="form.date.range.start" 
      mode="time" 
      hide-time-header
      is24hr
    />
    Exit time:
    <Calendar 
      v-model="form.date.range.end" 
      mode="time" 
      hide-time-header
      is24hr
    />
  </div>
</template>
</Calendar>

The problem is that without this fix, the navigation chevrons appear:

CleanShot 2024-01-17 at 19 38 35

@hrynevychroman
Copy link
Collaborator

hrynevychroman commented Jan 17, 2024

🔥 needed feature 💯

Copy link
Collaborator

@sadeghbarati sadeghbarati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Hope props and attrs merge later in Vue cause this abstraction makes things harder

@sadeghbarati sadeghbarati merged commit 8e7bbe3 into unovue:dev Jan 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants