feat: CSS3 variables & improved CSS dev experience #1748
+7,410
−3,197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackspear
force-pushed
the
feat/css3-variables
branch
from
1010873
to
b7397df
Compare
SimonFair
reviewed
Jul 3, 2024
zackspear
force-pushed
the
feat/css3-variables
branch
from
1b586a7
to
de822a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off the original work done in #1425. Huge shout out to @BaileyJM02 for the hard work with the initial setup for this.
The purpose of this PR is to lay the ground work for future CSS enhancements and improving the developer experience for styles.
Removing the idea of have multiple CSS files for theming differences. Ideally there's a singular base CSS file (should work for both layout types) with all colors using CSS variables. And the theme files are used to solely set CSS variables for color differences, instead of copied and pasted styles with different colors. Less duplicated code should make maintaining and adding new styles easier while also being less prone to errors.