Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed uploading documents and thumbnails #138

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

DJTommek
Copy link
Contributor

I've noticed, that sending files using SendDocument() is not working, including examples/send-document.php. So after a while of debugging I discovered few issues and fixed them.

During that process I needed to test various things so I also updated and also extended some examples to get bigger picture what can be done with response.

Copy link
Collaborator

@NanoSector NanoSector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Scrutinizer also seems happy. CC @unreal4u

@unreal4u unreal4u merged commit d816bfd into unreal4u:master Sep 14, 2021
@DJTommek DJTommek deleted the pr/file-upload-fix branch September 14, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants