Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook $secret_token #146

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Webhook $secret_token #146

merged 3 commits into from
Jul 28, 2022

Conversation

DJTommek
Copy link
Contributor

  • added support for SetWebhook::$secret_token
  • added example/set-webhook.php

Copy link
Collaborator

@NanoSector NanoSector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You add a property, but it doesn't actually do anything as of yet looking at the code, so what is the purpose of setting it like this?

$promise = $tgLog->performApiRequest($webhook);
$promise->then(
function (TelegramTypes $response) {
var_dump('Webhook was successfully set. Run get-webhookinfo.php to get detailed information about webhook from server.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be turned into an echo instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to echo, @NanoSector.

Copy link
Collaborator

@NanoSector NanoSector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I forgot these things get serialised based on properties. LGTM then, minor comment on the example.

@unreal4u unreal4u merged commit 70f478d into unreal4u:master Jul 28, 2022
@DJTommek DJTommek deleted the pr/set-webhook branch September 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants