Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RoPE extension #846

Merged
merged 14 commits into from
Jul 31, 2024
Merged

Fix RoPE extension #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
42e09d1
bugs
danielhanchen Jul 31, 2024
79ef745
Update _utils.py
danielhanchen Jul 31, 2024
9617ecb
flash-attn softcapping
danielhanchen Jul 31, 2024
d326c98
Update gemma2.py
danielhanchen Jul 31, 2024
86b71c4
Update gemma2.py
danielhanchen Jul 31, 2024
cf1054c
Update gemma2.py
danielhanchen Jul 31, 2024
8db7e80
Update gemma2.py
danielhanchen Jul 31, 2024
0c932bc
Update mapper.py
danielhanchen Jul 31, 2024
7af6320
Update README.md
danielhanchen Jul 31, 2024
fdfe1f5
Update _utils.py
danielhanchen Jul 31, 2024
0ebbcdf
Merge branch 'main' into nightly
danielhanchen Jul 31, 2024
2de1427
Fix ROPE extension issue and device mismatch (#840)
xyangk Jul 31, 2024
fdab3d6
Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…
danielhanchen Jul 31, 2024
d0a7dce
Update gemma.py
danielhanchen Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion unsloth/models/gemma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from .llama import *
from ._utils import __version__
import math

try:
from transformers.models.gemma.modeling_gemma import (
Expand Down Expand Up @@ -256,7 +257,7 @@ def forward(self, x, position_ids=None, seq_len=None):
def extend_rope_embedding(self, x, seq_len):
if seq_len <= self.current_rope_size: return
# Iteratively grow by increments of 8192
self.current_rope_size = int(round(seq_len / 8192)) * 8192
self.current_rope_size = math.ceil(seq_len / 8192) * 8192
self._set_cos_sin_cache(self.current_rope_size, device = "cuda:0", dtype = x.dtype)
pass
pass
Expand Down
7 changes: 4 additions & 3 deletions unsloth/models/llama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import torch
import gc
import math
from typing import Optional, Tuple, List, Union
from ._utils import *
from ._utils import __version__
Expand Down Expand Up @@ -1036,7 +1037,7 @@ def forward(self, x, position_ids=None, seq_len=None):
def extend_rope_embedding(self, x, seq_len):
if seq_len <= self.current_rope_size: return
# Iteratively grow by increments of 8192
self.current_rope_size = int(round(seq_len / 8192)) * 8192
self.current_rope_size = math.ceil(seq_len / 8192) * 8192
self._set_cos_sin_cache(self.current_rope_size, device = "cuda:0", dtype = x.dtype)
pass
pass
Expand Down Expand Up @@ -1109,7 +1110,7 @@ def _set_cos_sin_cache(self, seq_len, device, dtype):
# in FP32. They are applied (multiplied) in FP32 as well.
self.current_rope_size = seq_len

t = torch.arange(self.current_rope_size, device="cpu", dtype=torch.int64).float()
t = torch.arange(self.current_rope_size, device=self.inv_freq.device, dtype=torch.int64).float()

freqs = torch.outer(t, self.inv_freq)
# Different from paper, but it uses a different permutation in order to obtain the same calculation
Expand Down Expand Up @@ -1158,7 +1159,7 @@ def forward(self, x, position_ids=None, seq_len=None):
def extend_rope_embedding(self, x, seq_len):
if seq_len <= self.current_rope_size: return
# Iteratively grow by increments of 8192
self.current_rope_size = int(round(seq_len / 8192)) * 8192
self.current_rope_size = math.ceil(seq_len / 8192) * 8192
self._set_cos_sin_cache(self.current_rope_size, device = "cuda:0", dtype = x.dtype)
pass
pass
Expand Down