[REG-1430] RegistrarCustody contract #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickshatilo
force-pushed
the
nickshatilo/REG-1430/registrar-custody-contract
branch
from
0c9418e
to
ac62b75
Compare
nickshatilo
force-pushed
the
nickshatilo/REG-1430/registrar-custody-contract
branch
from
ac62b75
to
457aece
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _disableInitializers(); | ||
| } | ||
|
|
||
| function initialize(address _unsRegistry, address _mintingManager) public initializer { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| _disableInitializers(); | ||
| } | ||
|
|
||
| function initialize(address _unsRegistry, address _mintingManager) public initializer { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
Comment on lines
+116
to
+97
| function _msgData() internal view override(ContextUpgradeable, ERC2771RegistryContext) returns (bytes calldata) { | ||
| return ERC2771RegistryContext._msgData(); | ||
| } |
Check warning
Code scanning / Slither
Dead-code Warning
nickshatilo
force-pushed
the
nickshatilo/REG-1430/registrar-custody-contract
branch
from
457aece
to
821990b
Compare
nickshatilo
force-pushed
the
nickshatilo/REG-1430/registrar-custody-contract
branch
from
821990b
to
6b6a567
Compare
Contracts size report
|
Comment on lines
+73
to
+79
| function safeTransfer(address to, uint256 tokenId) external onlyMinter nonReentrant { | ||
| _protectTokenOperation(tokenId); | ||
|
|
||
| unsRegistry.setOwner(to, tokenId); | ||
|
|
||
| delete virtualOwners[tokenId]; | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
1. Contracts versioning
patchversion of the contracts is increased if changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustodycontracts.minorversion of the contracts is increased if breaking changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustodycontracts. It includes changes of interfaces.2. Contracts licensing
3. Coverage
4. Configs versioning
uns-config.jsonis increased if changes have been made to the config.ens-config.jsonis increased if changes have been made to the config.resolver-keys.jsonis increased if changes have been made to the config.ens-resolver-keys.jsonis increased if changes have been made to the config.5. Package versioning
patchversion of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minorversion of package is synced with version ofUNSRegistrycontract.CHANGELOGis updated with short description for the new version.6. Code review
resolver-keys.jsoncode review is required from DevTools teamens-resolver-keys.jsoncode review is required from DevTools team