Skip to content

Commit

Permalink
refactor github actions iteration=6
Browse files Browse the repository at this point in the history
fix error in github actions.
for context see #1044

Issue: #1030
Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]>
  • Loading branch information
Ndibe Raymond Olisaemeka committed Dec 21, 2023
1 parent 5ea2ffd commit 10bbd14
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_deploy_frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
uses: unstructuredstudio/zubhub/.github/actions/checkout@master
- uses: unstructuredstudio/zubhub/.github/actions/checkout@master

- name: Build and push frontend
uses: unstructuredstudio/zubhub/.github/actions/docker_build_and_push@master
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/create_destroy_test_vm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
# See https://stackoverflow.com/questions/75873833/how-to-protect-github-secrets-in-pull-request-actions-from-malicious-pull-reques
# See https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git
# See https://dev.to/suzukishunsuke/secure-github-actions-by-pullrequesttarget-641#:~:text=pull_request_target%20is%20one%20of%20the,the%20pull%20request's%20base%20branch.
uses: unstructuredstudio/zubhub/.github/actions/checkout@master
- uses: unstructuredstudio/zubhub/.github/actions/checkout@master
with:
ref: ${{ env.CHECKOUT_COMMIT_REF }}
repository: ${{ env.CHECKOUT_REPO }}
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
doctl compute domain records create unstructured.studio --record-type A --record-name \
$MEDIA_DOMAIN --record-data $NEW_DROPLET_IP --record-ttl 600
uses: unstructuredstudio/zubhub/.github/actions/scp_action@master
- uses: unstructuredstudio/zubhub/.github/actions/scp_action@master
with:
host: ${{env.NEW_DROPLET_IP}}
username: ${{ secrets.DO_BACKEND_USERNAME }}
Expand All @@ -110,6 +110,7 @@ jobs:
echo "MEDIA_DOMAIN=$MEDIA_DOMAIN" >> $GITHUB_OUTPUT
echo "CHECKOUT_COMMIT_REF=${{ env.CHECKOUT_COMMIT_REF }}" >> $GITHUB_OUTPUT
echo "CHECKOUT_REPO=${{ env.CHECKOUT_REPO }}" >> $GITHUB_OUTPUT
outputs:
NEW_DROPLET_IP: ${{ steps.set_output.outputs.NEW_DROPLET_IP }}
FRONTEND_DOMAIN: ${{ steps.set_output.outputs.FRONTEND_DOMAIN }}
Expand Down Expand Up @@ -145,7 +146,7 @@ jobs:
# See https://stackoverflow.com/questions/75873833/how-to-protect-github-secrets-in-pull-request-actions-from-malicious-pull-reques
# See https://stackoverflow.com/questions/74957218/what-is-the-difference-between-pull-request-and-pull-request-target-event-in-git
# See https://dev.to/suzukishunsuke/secure-github-actions-by-pullrequesttarget-641#:~:text=pull_request_target%20is%20one%20of%20the,the%20pull%20request's%20base%20branch.
uses: unstructuredstudio/zubhub/.github/actions/checkout@master
- uses: unstructuredstudio/zubhub/.github/actions/checkout@master
with:
ref: ${{ env.CHECKOUT_COMMIT_REF }}
repository: ${{ env.CHECKOUT_REPO }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/locust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
steps:
- name: Create new DO droplet
id: create_droplet
uses: unsctructuredstudio/zubhub/.github/actions/doctl@master
uses: unstructuredstudio/zubhub/.github/actions/doctl@master
with:
token: ${{ secrets.DO_ACCESS_TOKEN }}
script: |
Expand Down

0 comments on commit 10bbd14

Please sign in to comment.