Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Improve search for non-logged-in users #1087

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

brrkrmn
Copy link
Collaborator

@brrkrmn brrkrmn commented Jan 19, 2024

Summary

This PR addresses the intended flow explained here. Now, logged-out users can search for projects and creators

Closes #802

Changes

Although this PR is to make changes for non-logged-in users, I kept some of the changes that also affect logged-in user's experience but can remove them upon your comments.

For non-logged-in users:

  • Search dropdown is disabled
  • If the query matches with multiple results, they only see 3 of them at most
  • they see a login form when they make search with or without results
  • If there are no results, 3 staff pick projects are shown instead (only for project search)

For logged-in users:

  • They also see the staff pick projects when their project search yields no results
  • When they make a creator search with no results, they see the same page with non-logged-in users except for the login form

To Do

  • Make the results' paths directly accessible by non-loggers but limit the other projects/creators

Screenshots

Please see how results look for different combinations here

Here is a quick demonstration of how search looks like for an unauthenticated user:

Screen.Recording.2024-01-19.at.3.31.26.PM.mov

Further Improvement

There are some things to be improved for the overall search feature, which can be a part of another PR. Some of them are:

  • Currently, tag search is not possible
  • Styles should be made more unified since there are a lot of inconsistencies
  • Searching for projects or creators is not possible unless the user types a whole word (e.g. searching for '' does not work)

@brrkrmn
Copy link
Collaborator Author

brrkrmn commented Jan 22, 2024

Update: results not overflowing 1 row for non-logged-in users

@brrkrmn brrkrmn marked this pull request as ready for review January 29, 2024 10:48
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the Sanskrit translation, I have a pro-tip:
Since we already have the english sentence, we can copy it, search "translate english to sanskrit" on google, paste the english sentence in the translation form and get the sanskrit from the other

@NdibeRaymond
Copy link
Collaborator

code looks ok but still need to test the UI with user data

@NdibeRaymond NdibeRaymond changed the base branch from master to staging June 3, 2024 00:59
* style page and add login card
* fix misaligned login form in search results
* change styles for creator search
* implement no results found design
* make results one row
* made some major refactors

Issue: #802
Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]>
@NdibeRaymond
Copy link
Collaborator

had to refactor a lot of things here (some of which are not directly related to this patch but still hurts my eyes). It's good to go now

Copy link

All pre-commit checks passed ✅✅✅

@NdibeRaymond NdibeRaymond merged commit 85aad49 into staging Jun 17, 2024
5 checks passed
NdibeRaymond pushed a commit that referenced this pull request Jul 17, 2024
* style page and add login card
* fix misaligned login form in search results
* change styles for creator search
* implement no results found design
* make results one row
* made some major refactors

Issue: #802

Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]>
Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is broken for non-logged in users
2 participants