Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes the scroll effect #890

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: fixes the scroll effect #890

merged 1 commit into from
Oct 17, 2023

Conversation

yokwejuste
Copy link
Collaborator

Summary

Description of PR here...
Closes #822

Changes

  • Team review section

Screenshots

scroll-record.mp4

@yokwejuste
Copy link
Collaborator Author

@DonPresh here is the PR I made, waiting for @srish and @tuxology to make a review

@tuxology
Copy link
Member

tuxology commented Oct 15, 2023 •
edited
Loading

@kamthamc Need your review here. I feel there should be a more straightforward way than hardcoded styles in Home.jsx. IN addition, @yokwejuste I don't understand how this is related to vertical scrolling issues. This is adding two new buttons for horizontal scrolling. We don't need them - we just need to fix vertical scrolling for now. On mobile, these can be swiped if needed (that would be an acceptable addition)

@DonPresh
Copy link

@yokwejuste Can you pls show what it looks when you try to scroll past? The main issue here is trying to scroll past this area. How does this solve the problem? Also you omitted the image that was in the original design. Please review and make corrections.

@yokwejuste
Copy link
Collaborator Author

@yokwejuste Can you pls show what it looks when you try to scroll past? The main issue here is trying to scroll past this area. How does this solve the problem? Also you omitted the image that was in the original design. Please review and make corrections.

Check the video attached please

tuxology
tuxology approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@tuxology tuxology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌈

@tuxology tuxology merged commit 4a2c8a7 into unstructuredstudio:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanya-cloudknox chaitanya-cloudknox chaitanya-cloudknox left review comments

@DonPresh DonPresh DonPresh left review comments

@tuxology tuxology tuxology approved these changes

@NdibeRaymond NdibeRaymond Awaiting requested review from NdibeRaymond NdibeRaymond is a code owner

@kamthamc kamthamc Awaiting requested review from kamthamc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical scroll is not functional past creator review section on landing page on mobile
4 participants
@yokwejuste @tuxology @DonPresh @chaitanya-cloudknox