Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): go back arrows redirect to correct page #895

Merged
merged 12 commits into from
Oct 13, 2023

Conversation

brrkrmn
Copy link
Collaborator

@brrkrmn brrkrmn commented Oct 13, 2023

Summary

Although #846 was closed, I noticed that the go back arrow in the create project page redirects the user to the projects page. However, it should redirect the user to project mode selection page. Also the arrow in create team page had no function, with this PR, it redirects the user to the previous step.

Closes #846

Changes

  • KeyboardBackspaceRoundedIcon in CreateProject.jsx redirects to /project/create
  • KeyboardBackspaceRoundedIcon in CreateTeam.jsx redirects to /create-team
  • Remove unused class backLink

Before

Screen.Recording.2023-10-13.at.20.06.22.mov

After

Screen.Recording.2023-10-13.at.20.06.59.mov

Copy link
Member

@tuxology tuxology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM 🌈

@tuxology tuxology merged commit 15d6416 into unstructuredstudio:master Oct 13, 2023
@brrkrmn brrkrmn deleted the go-back-fix branch October 13, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back icon in create project screen does not function in mobile
2 participants