Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Build with Go 1.16.1, and remove the whitelist of supported versions #140

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Build with Go 1.16.1, and remove the whitelist of supported versions #140

merged 1 commit into from
Mar 11, 2021

Commits on Mar 11, 2021

  1. Build with Go 1.16.1, and remove the whitelist of supported versions

    #122 (comment)
    
    Per the above comment thread, most (all?) of our projects now use Go modules,
    which allow a module to declare the version of Go it targets.
    
    It could be that the purpose of this variable is to gate the versions of Go that
    upbound/build as a library of Makefiles supports, rather than the versions of Go
    that code built with upbound/build supports. If this is the case, I'd argue that
    during the the two years I've been using this library we've yet to encounter a
    new version of Go that has required anything other than a bump to this whitelist
    and that we never test that the older versions of Go still work. I suspect it
    would be more productive to pay the price of a newer version of Go breaking the
    library if and when that becomes an issue than it currently is to bump the var
    every time a new version of Go is released.
    
    Signed-off-by: Nic Cope <[email protected]>
    negz committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b0d0745 View commit details
    Browse the repository at this point in the history