Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Support Go 1.19 #200

Closed
wants to merge 1 commit into from
Closed

Support Go 1.19 #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions makelib/golang.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
# Optional. The Go Binary to use
GO ?= go

# Optional. Required Go version.
GO_REQUIRED_VERSION ?= 1.18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_REQUIRED_VERSION is not referenced in any repo:

# Optional. Supported Go versions.
GO_SUPPORTED_VERSIONS ?= 1.18|1.19

# The go project including repo name, for example, github.com/rook/rook
GO_PROJECT ?= $(PROJECT_REPO)
Expand Down Expand Up @@ -89,8 +89,9 @@ GOIMPORTS_VERSION ?= v0.1.12

GOHOST := GOOS=$(GOHOSTOS) GOARCH=$(GOHOSTARCH) $(GO)
GO_VERSION := $(shell $(GO) version | sed -ne 's/[^0-9]*\(\([0-9]\.\)\{0,4\}[0-9][^.]\).*/\1/p')
ifneq ($(GO_VERSION),$(GO_REQUIRED_VERSION))
$(error "$(GO) version $(GO_VERSION) is not supported. required version is $(GO_REQUIRED_VERSION)")
GO_FULL_VERSION := $(shell $(GO) version)
ifneq ($(shell $(GO) version | grep -q -E '\bgo($(GO_SUPPORTED_VERSIONS))\b' && echo 0 || echo 1), 0)
$(error unsupported: $(GO_FULL_VERSION). Please make install one of the following supported version: '$(GO_SUPPORTED_VERSIONS)')
endif

# we use a consistent version of gofmt even while running different go compilers.
Expand Down