Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guarded more imports to fix #33 #34

Merged
merged 2 commits into from
Nov 6, 2023
Merged

guarded more imports to fix #33 #34

merged 2 commits into from
Nov 6, 2023

Conversation

whitead
Copy link
Contributor

@whitead whitead commented Nov 3, 2023

No description provided.

@maykcaldas
Fixed botorch version
86a46fb 
Fixed botorch version to 0.9.2. Function `botorch.optim.fit.fit_gpytorch_torch`  was deprecated in v0.9.3
@maykcaldas
Copy link
Contributor

Botorch deprecated the function botorch.optim.fit.fit_gpytorch_torch in v0.9.3.
Removed in #1995

maykcaldas
maykcaldas approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@maykcaldas maykcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the botorch version, the tests are passing and the import issue seems to be solved

@maykcaldas maykcaldas merged commit bf1e697 into main Nov 6, 2023
3 checks passed
@maykcaldas maykcaldas deleted the issue-33 branch April 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maykcaldas maykcaldas maykcaldas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitead @maykcaldas