fix: remove omitempty tag for boolean leaveOnDelete #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overriding the default value "true" for the boolean leaveOnDelete doesn't work. Even if the CRD is created with a default value "false" the conversion webhook uses the default value "true" from the operator's PassboltSecretSpec to create the passbolt secret.
It seems that the omitempty tag for boolean leaveOnDelete prevents parsing the value when set to "false" (as it is the zero value for booleans) and then the default webhook is kicking as it doesn't see any value for that field.
A similar issue can be fount here:
kubernetes-sigs/kubebuilder#2109
Checklist