Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in v2-maint #1980

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Update dependencies in v2-maint #1980

merged 2 commits into from
Oct 13, 2024

Conversation

meatballhat
Copy link
Member

What type of PR is this?

  • maintenance

What this PR does / why we need it:

Update to latest dependency versions and introduce diffing to the file comparison test func, but without bringing in a dependency like the v1-maint branch.

Which issue(s) this PR fixes:

N/A

and update the file comparison helper to diff when available
rather than introducing another dependency like this is done in the
`v1-maint` branch via github.com/stretchr/testify/require
@meatballhat meatballhat added area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work labels Oct 13, 2024
@meatballhat meatballhat marked this pull request as ready for review October 13, 2024 00:42
@meatballhat meatballhat requested a review from a team as a code owner October 13, 2024 00:42
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@meatballhat meatballhat merged commit f035ffa into v2-maint Oct 13, 2024
13 checks passed
@meatballhat meatballhat deleted the v2-update-deps branch October 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/maintenance about releasing / CI / Github / other kind of "meta" project maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants