Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Support passing a WebSocket.Server options object to the FirebaseServer constructor #101

Merged
merged 2 commits into from
Aug 18, 2017

Conversation

tommie
Copy link
Contributor

@tommie tommie commented Aug 18, 2017

This is useful to start a Firebase server on an existing http.Server, like the webpack dev server.

@coveralls
Copy link

coveralls commented Aug 18, 2017

Coverage Status

Coverage increased (+0.07%) to 96.835% when pulling 1043fe5 on tommie:master into 0c86771 on urish:master.

…er constructor.

This is useful to start a Firebase server on an existing http.Server.
@coveralls
Copy link

coveralls commented Aug 18, 2017

Coverage Status

Coverage increased (+0.09%) to 96.855% when pulling 7e96f9a on tommie:master into 0c86771 on urish:master.

@urish urish merged commit 1ae90a0 into urish:master Aug 18, 2017
@urish
Copy link
Owner

urish commented Aug 18, 2017

Thanks!

@urish
Copy link
Owner

urish commented Aug 19, 2017

released as 0.11.0

@tommie
Copy link
Contributor Author

tommie commented Aug 19, 2017

Thanks!

Gabrn pushed a commit to Gabrn/firebase-server that referenced this pull request Aug 30, 2017
…er constructor (urish#101)

* Remove some trailing whitespace in README.md.

* Support passing a WebSocket.Server options object to the FirebaseServer constructor.

This is useful to start a Firebase server on an existing http.Server.
p-salido pushed a commit to p/firebase-server that referenced this pull request Oct 3, 2017
* origin/master:
  chore: release 0.11.0
  chore: add package-lock.json
  doc: add a note about `-s` argument
  doc: add link to explain tryRead() issue
  Migrate to Targaryen 3 (urish#100)
  Support passing a WebSocket.Server options object to the FirebaseServer constructor (urish#101)
  Fix security rules validation for updates (urish#99)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants