Strip extra lines before and after the _WARNING_MSG #1117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for
fastapi_pagination/utils.py:_WARNING_MSG
is to remove the extra lines from it. This makes it easier to filter warnings in pytest and other tools.I've made a proof of concept for this PR https://github.com/frost-nzcr4/fastapi-pagination/tree/poc-pytest-filterwarning-not-matching-the-warning/docker.
You'll need to run:
and now you get ready for an error:
The leading
\n
in_WARNING_MSG
is non-obvious to filter with pytest filterwarnings and with-W
.