Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Support total parameter for tortoise ext #1269

Merged
merged 2 commits into from
Sep 8, 2024
Merged

✨ Support total parameter for tortoise ext #1269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39253a2
✨ Support `total` parameter for tortoise ext
waketzheng Sep 2, 2024
713091d
Merge branch 'main' into main
uriyyo Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fastapi_pagination/ext/tortoise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,14 @@
*,
transformer: Optional[AsyncItemsTransformer] = None,
additional_data: Optional[AdditionalData] = None,
total: Optional[int] = None,
) -> Any:
params, raw_params = verify_params(params, "limit-offset")

if not isinstance(query, QuerySet):
query = query.all()

total = await query.count() if raw_params.include_total else None
if total is None and raw_params.include_total:
total = await query.count()

Check warning on line 45 in fastapi_pagination/ext/tortoise.py

View check run for this annotation

Codecov / codecov/patch

fastapi_pagination/ext/tortoise.py#L44-L45 

Added lines #L44 - L45 were not covered by tests
items = await generic_query_apply_params(_generate_query(query, prefetch_related), raw_params).all()
t_items = await apply_items_transformer(items, transformer, async_=True)

Expand Down