Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ctx var resetting #310

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Fix issue with ctx var resetting #310

merged 2 commits into from
Apr 16, 2022

Conversation

uriyyo
Copy link
Owner

@uriyyo uriyyo commented Apr 14, 2022

Fixes #309

@uriyyo uriyyo added the bug Something isn't working label Apr 14, 2022
@uriyyo uriyyo self-assigned this Apr 14, 2022
@uriyyo uriyyo force-pushed the bugfix/reset-ctx-value-error branch from e801b44 to 2c495a5 Compare April 14, 2022 10:26
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #310 (804f26f) into main (02c2de9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          26       26           
  Lines         502      503    +1     
=======================================
+ Hits          499      500    +1     
  Misses          3        3           
Impacted Files Coverage Δ
fastapi_pagination/api.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c2de9...804f26f. Read the comment docs.

@uriyyo uriyyo merged commit 85884fb into main Apr 16, 2022
@uriyyo uriyyo deleted the bugfix/reset-ctx-value-error branch April 16, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using fastapi middleware and fastapi-pagination together
1 participant