Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Cursor pagination #376

Merged
merged 11 commits into from
Sep 12, 2022
Merged

Initial Cursor pagination #376

merged 11 commits into from
Sep 12, 2022

Conversation

uriyyo
Copy link
Owner

@uriyyo uriyyo commented Sep 12, 2022

@uriyyo uriyyo added the enhancement New feature or request label Sep 12, 2022
@uriyyo uriyyo self-assigned this Sep 12, 2022
@uriyyo uriyyo marked this pull request as draft September 12, 2022 11:13
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #376 (ad92410) into main (8d7e5b1) will decrease coverage by 0.80%.
The diff coverage is 92.30%.

❗ Current head ad92410 differs from pull request most recent head b540a72. Consider uploading reports for the commit b540a72 to get more accurate results

@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   99.30%   98.49%   -0.81%     
==========================================
  Files          31       32       +1     
  Lines         576      665      +89     
==========================================
+ Hits          572      655      +83     
- Misses          4       10       +6     
Impacted Files Coverage Δ
fastapi_pagination/api.py 100.00% <ø> (ø)
fastapi_pagination/ext/motor.py 100.00% <ø> (ø)
fastapi_pagination/ext/sqlalchemy_future.py 84.37% <75.00%> (-15.63%) ⬇️
fastapi_pagination/ext/sqlalchemy.py 93.24% <90.56%> (-6.76%) ⬇️
fastapi_pagination/bases.py 100.00% <100.00%> (ø)
fastapi_pagination/cursor.py 100.00% <100.00%> (ø)
fastapi_pagination/default.py 100.00% <100.00%> (ø)
fastapi_pagination/ext/async_sqlalchemy.py 100.00% <100.00%> (+13.33%) ⬆️
fastapi_pagination/ext/async_sqlmodel.py 100.00% <100.00%> (+10.52%) ⬆️
fastapi_pagination/ext/databases.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@uriyyo uriyyo marked this pull request as ready for review September 12, 2022 14:32
@uriyyo uriyyo changed the title WIP; Initial Cursor pagination Initial Cursor pagination Sep 12, 2022
@uriyyo uriyyo merged commit 2af2539 into main Sep 12, 2022
@uriyyo uriyyo deleted the feature/cursor-pagination branch September 12, 2022 14:33
@fruch
Copy link
Contributor

fruch commented Sep 13, 2022

Whoo, that was fast...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants