Fix bug with optional params and page creation #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rigaud
reviewed
Apr 9, 2023
| @@ -59,13 +59,15 @@ def create( | |||
| if not isinstance(params, Params): | |||
| raise ValueError("Page should be used with Params") | |||
|
|
|||
| pages = ceil(total / params.size) if total is not None else None | |||
| size = params.size if params.size is not None else total | |||
| page = params.page if params.page is not None else 1 | |||
There was a problem hiding this comment.
@uriyyo
Isn't page = params.page or 1 better in this case ? As page 0 should not be accepted
Same for size ?
There was a problem hiding this comment.
@s-rigaud Thanks for your suggestion.
We can have custom params that can use zero-based pagination. page = params.page or 1 can produce bugs, cause we never now how end-user customization will look like.
There was a problem hiding this comment.
Oh ok I understand, thanks for the response 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.