always disable the builtin hostname verification #526
Conversation
t-8ch
force-pushed
the
disable_builtin_hostname_verification
branch
2 times, most recently
from
8c47d80
to
5a61b61
Compare
|
I give up on travis. Tried 3 times and everytime some random timeout or proxy test broke. |
|
LGTM, though we do need a clean test run. |
|
So I'm -1 on this. If I can get some time to work on #507 and move the context logic into that method (like was suggested in the review comments) then this wouldn't be necessary and we'll be able to handle this logic a lot better. |
|
@sigmavirus24 What's your ETA? I'm cool on blocking on your fix if it's soon-ish. :) |
|
@Lukasa Do you think this is urgent enough to push out a 1.10.1 hotfix, or should we wait for @sigmavirus24 to Fix It Properly? :P |
|
Ehh....pass? The summary is that hostname verification is broken in 1.10, and if you do anything other than the default behaviour the stdlib will ruin your day. Now, it might be enough to publish an advisory that says "hey, 1.10 has this bug in it, please avoid upgrading if you rely on this functionality" and then wait for @sigmavirus24. That way we never have a temporary fix in place. |
|
If only there was some medium to publish such an advisory on that is not my twitter account. :P |
|
Haha, quite. |
|
We should also add a test case for this issue. Even if this might not break in the future, a test case would prevent a release if the functionality is broken somewhere else. |
It conflicts with our own, more flexible functionality Fixes urllib3#524
t-8ch
force-pushed
the
disable_builtin_hostname_verification
branch
from
5a61b61
to
6340b18
Compare
|
There comes a patch. |
|
👍 when the tests pass |
|
They passed, finally... |
|
LGTM. 👍 🍰 |
always disable the builtin hostname verification.
|
Howdy all, Any chance you can cut a new release that includes this? I'm relatively sure that we're running into #543 and I'd be willing to pitch in if needed so we can get pip (and thus virtualenv) upgraded. Thanks! |
|
@Yasumoto Good call. How about early next week? We have a couple of issues I'd like to get merged and then push out 1.10.1 |
|
That sounds awesome! We're pretty far downstream, so much appreciated :) |
It conflicts with our own, more flexible functionality
Fixes #524