refactor(core): Refactor hasNext/stale on OperationResult to be requi…

…red (#3061)

.changeset/four-boxes-impress.md

@@ -0,0 +1,7 @@
+---
+'@urql/exchange-graphcache': major
+'@urql/svelte': major
+'@urql/core': major
+---
+
+Update `OperationResult.hasNext` and `OperationResult.stale` to be required fields. If you have a custom exchange creating results, you'll have to add these fields or use the `makeResult`, `mergeResultPatch`, or `makeErrorResult` helpers.

exchanges/auth/src/authExchange.test.ts

@@ -21,13 +21,16 @@ import {
 
 import { vi, expect, it } from 'vitest';
 import { print } from 'graphql';
-import { queryOperation } from '../../../packages/core/src/test-utils';
+import {
+  queryResponse,
+  queryOperation,
+} from '../../../packages/core/src/test-utils';
 import { authExchange } from './authExchange';
 
 const makeExchangeArgs = () => {
   const operations: Operation[] = [];
   const result = vi.fn(
-    (operation: Operation): OperationResult => ({ operation })
+    (operation: Operation): OperationResult => ({ ...queryResponse, operation })
   );
 
   return {
@@ -247,7 +250,9 @@ it('triggers authentication when an operation did error', async () => {
   await new Promise(resolve => setTimeout(resolve));
 
   result.mockReturnValueOnce({
+    ...queryResponse,
     operation: queryOperation,
+    data: undefined,
     error: new CombinedError({
       graphQLErrors: [{ message: 'Oops' }],
     }),

exchanges/context/src/context.test.ts

@@ -9,6 +9,7 @@ import {
   ExchangeIO,
 } from '@urql/core';
 
+import { queryResponse } from '../../../packages/core/src/test-utils';
 import { contextExchange } from './context';
 
 const queryOne = gql`
@@ -48,6 +49,7 @@ it(`calls getContext`, () => {
   const response = vi.fn(
     (forwardOp: Operation): OperationResult => {
       return {
+        ...queryResponse,
         operation: forwardOp,
         data: queryOneData,
       };
@@ -83,6 +85,7 @@ it(`calls getContext async`, async () => {
   const response = vi.fn(
     (forwardOp: Operation): OperationResult => {
       return {
+        ...queryResponse,
         operation: forwardOp,
         data: queryOneData,
       };

exchanges/execute/src/execute.test.ts

@@ -272,6 +272,7 @@ describe('on success response', () => {
       operation: queryOperation,
       data: mockHttpResponseData,
       hasNext: false,
+      stale: false,
     });
   });
 });