Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(core) - filter network-only requests from the ssrExchange (#2198)
* filter network-only requests from the ssrExchange On the prior lines we defer clearing the data by a microtick which means that the redispatched "network-only" request will also be served from the ssr-cache. We could also opt to defer the redispatch by a microtick but imo it's better to treat network-only requests as bypassing this. Another possible solution would be to check whether we've seen this before as a `revalidation` * Create strong-islands-hope.md * formatting
- Loading branch information
c4a0ede
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoviDeCroock To me it seems that this change completely breaks
network-only
policy with SSR:network-only
operations are cached by SSR and thus part ofextractData()
data
cache) nor added to the result stream (because of your change here)https://github.com/FormidableLabs/urql/blob/bea39c2eb4a93669f5d1d4ee775dfc45cf56a39d/packages/core/src/exchanges/ssr.ts#L126-L132
This results in an operation that just get's swallowed, i.e. it never emits any result.
Before opening an issue maybe you can explain again why this fix was neccessary. As I'm new to urql I don't get what you mean by "microticks" (I understand wonka + streams, though).