Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@urql/exchange-populate: fragments breaking in versions >=0.2.0 #1149

Closed
zachasme opened this issue Nov 12, 2020 · 1 comment · Fixed by #2897
Closed

@urql/exchange-populate: fragments breaking in versions >=0.2.0 #1149

zachasme opened this issue Nov 12, 2020 · 1 comment · Fixed by #2897
Labels
bug 🐛 Oh no! A bug or unintented behaviour. hold ⚠️ This issue is accepted but no contributor is available yet or prerequisites must be fulfilled first.

Comments

@zachasme
Copy link

The populate exchange is causing TypeErrors after upgrading from 0.1.8. I've made a sandbox reproducing the issue. It only throws when using a fragment with nested fields. If I remove projectMemberships from the fragment or downgrade @urql/exchange-populate it does not throw.

urql version & exchanges:

  • urql 1.11.2
  • @urql/exchange-populate 0.2.1

Steps to reproduce

  1. Open this sandbox reproducing the issue
  2. Select a @urql/exchange-populate version above >=0.2.0.

Expected behavior
No observable changes in behavior.

Actual behavior
image
@zachasme zachasme added the bug 🐛 Oh no! A bug or unintented behaviour. label Nov 12, 2020
@kitten
Copy link
Member

kitten commented Nov 18, 2020

Ready to be picked up but may not be addressed immediately if #964 is also ready to be worked on

@kitten kitten mentioned this issue Nov 19, 2020
Closed
@JoviDeCroock JoviDeCroock mentioned this issue Nov 19, 2020
Closed
@kitten kitten added the hold ⚠️ This issue is accepted but no contributor is available yet or prerequisites must be fulfilled first. label Apr 28, 2021
@JoviDeCroock JoviDeCroock mentioned this issue Dec 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Oh no! A bug or unintented behaviour. hold ⚠️ This issue is accepted but no contributor is available yet or prerequisites must be fulfilled first.
Projects
None yet
Milestone
No milestone
2 participants
@zachasme @kitten