Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(populate) - skip visits inside of a FragmentDefinition #1175

Closed
wants to merge 1 commit into from

Conversation

JoviDeCroock
Copy link
Collaborator

Summary

Fixes: #1149

When we are inside of a Fragment we shouldn't resolve types, we copy them over either way to the mutation.

Set of changes

  • Add flag to skip Fragment traversal

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2020

🦋 Changeset detected

Latest commit: 9f90845

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-populate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten changed the title (populate-exchange) - skip visits inside of a FragmentDefinition (populate) - skip visits inside of a FragmentDefinition Nov 19, 2020
@JoviDeCroock
Copy link
Collaborator Author

Closing in favor of waiting for our full rewrite of the populate exchange, described in #964

@JoviDeCroock JoviDeCroock deleted the fix-fragments branch January 15, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@urql/exchange-populate: fragments breaking in versions >=0.2.0
3 participants