Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(next) - fix issue with next where staleWhileRevalidate would loop #1895

Merged
merged 1 commit into from
Aug 27, 2021
Merged

(next) - fix issue with next where staleWhileRevalidate would loop #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/six-walls-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'next-urql': patch
---

Fix issue where the `renderToString` pass would keep looping due to reexecuting operations on the server
5 changes: 4 additions & 1 deletion packages/next-urql/src/with-urql-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ export function withUrqlClient(
ssr = ssrExchange({
initialState: urqlServerState,
isClient: true,
staleWhileRevalidate: options!.staleWhileRevalidate,
staleWhileRevalidate:
typeof window !== 'undefined'
? options!.staleWhileRevalidate
: undefined,
});
} else if (!version) {
ssr.restoreData(urqlServerState);
Expand Down