Fix dedup ignoring torn down query operations #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a query was torn down, the dedup exchange wasn't removing its key from the inFlight keys. This was causing us to ignore torn down queries forever.
andyrichardson
approved these changes
Jun 8, 2019
| inFlight.add(key); | ||
| } | ||
| const afterOperationResult = ({ operation }: OperationResult) => { | ||
| inFlightKeys.delete(operation.key); |
There was a problem hiding this comment.
Is there a reason for not having this inline?
There was a problem hiding this comment.
Just to clean it up; I thought having names like afterOperationResult could help when someone's trying to figure out how those work
This was referenced Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #280
When a query was torn down, the dedup exchange wasn't
removing its key from the inFlight keys.
This was causing us to ignore torn down queries forever.