-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Update supported "Incremental Delivery" format/spec #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
force-pushed
the
feat/update-incremental-delivery
branch
from
March 6, 2023 15:13
21ff4cb
to
dd0f89d
Compare
JoviDeCroock
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3003
Summary
When applied, this pull request updates the "Incremental Delivery" spec format, as it should be supported according to the updated specification. It furthermore updates the permissible formats of execution results we accept from APIs.
While some minor adjustments have been made that could be breaking, we only changed things related to the prior experimental changes, as not merged to the spec yet.
Note: Combined gzip+min size of
*.min.js
went from6.11 kB
to6.27 kB
, a delta of+0.16kB
Set of changes
string
support for rehydrating errorsAccept
header format, as most APIs should reasonably support it