-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(persisted): Replace persistedFetchExchange with generic persistedExchange #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
force-pushed
the
feat/persisted-exchange
branch
from
March 15, 2023 21:34
74e3d09
to
3a010ba
Compare
We'll have to decide what to do with |
kitten
added
the
major 🚚
Changes queued for a new major release, which will include breaking changes
label
Mar 16, 2023
7 tasks
JoviDeCroock
approved these changes
Mar 16, 2023
kitten
force-pushed
the
feat/persisted-exchange
branch
from
March 16, 2023 17:20
af80008
to
3ce4cb7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2988
Resolves #2989
Summary
This change modifies
@urql/core/internal
to know how to modifyFetchBody
according to the (Automatic) Persisted Queries specification, leaving outquery
as needed.The
persistedExchange
replacespersistedFetchExchange
and hence also now works with third-party transports and thesubscriptionExchange
.Types have been added to
@urql/core
to reflect theextensions.persistedQuery
spec, with an addedmiss?: boolean
field, which is set whenquery
must be included again (i.e. when a persisted query "misses", via APQ)The
persistedExchange
must hence now be placed in front of the default fetch exchange, and/or in front of asubscriptionExchange
that handles queries.The package has been renamed to
@urql/exchange-persisted
to reflect this.Set of changes
@urql/exchange-persisted-fetch
to@urql/exchange-persisted
persistedQuery
types to extensions on@urql/core
query
inmakeFetchBody
persistedExchange
replacingpersistedFetchExchange
with generic retry logic