Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Handle refreshAuth rejections gracefully #3307

Merged
merged 1 commit into from
Jul 12, 2023
Merged

feat(auth): Handle refreshAuth rejections gracefully #3307

merged 1 commit into from
Jul 12, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 10, 2023

Summary

This adds a catch(errorQueue) case to refreshAuth and replaces finally(flushQueue) with then(flushQueue). The rejection case will issue OperationResults for all Operations in the queue and will pass the authentication error that refreshAuth rejected with on as the network error.

Set of changes

  • Add error handling to refreshAuth rejections

@kitten kitten merged commit 657bd0c into main Jul 12, 2023
6 checks passed
@kitten kitten deleted the feat/handle-auth-refresh-errors branch July 12, 2023 15:37
@github-actions github-actions bot mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kitten