Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persisted): Add missing teardown source #3312

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 12, 2023

Resolves #3311

Summary

Add missing teardown support to the persistedExchange. Since the hashing function is promisified and hence deferred, initial operation reads that are cancelled (i.e. particularly in React/Preact) need to cancel the ongoing operation correctly.

Set of changes

  • Add missing takeUntil teardown source to persistedExchange

@kitten kitten merged commit 1cf2e2f into main Jul 12, 2023
6 checks passed
@kitten kitten deleted the fix/persisted-teardown branch July 12, 2023 15:36
@github-actions github-actions bot mentioned this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

persistedExchange duplicates operations
1 participant