Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persisted): Allow nullish hashes for skipping persisted logic #3324

Merged
merged 1 commit into from
Jul 21, 2023
Merged

feat(persisted): Allow nullish hashes for skipping persisted logic #3324

merged 1 commit into from
Jul 21, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 21, 2023

Summary

This allows generateHash to resolve to null | undefined, effectively allowing the persisted logic to be skipped selectively for individual operations.

Set of changes

  • Allow null | undefined to be returned by generateHash
  • Add test for new case

@kitten kitten merged commit a685bc9 into main Jul 21, 2023
6 checks passed
@kitten kitten deleted the feat/allow-nullish-persisted-hash branch July 21, 2023 13:08
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kitten