-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) - remove useDevtoolsContext #387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks great to me @JoviDeCroock! Definitely merge ready once urql-graphql/urql-devtools-exchange#1 is published! |
parkerziegler
approved these changes
Aug 13, 2019
I've merged your changes in |
andyrichardson
approved these changes
Aug 14, 2019
I think we should hold off merging this until the devtools exchange changes have been published - but this looks ready to merge 👍 |
@andyrichardson definitely 👍 otherwise we'd diverge and we don't want that confusion on master for sure |
…o prevent potential crashes
JoviDeCroock
force-pushed
the
chore/removeUseDevtoolsContext
branch
from
August 20, 2019 13:37
29b5665
to
220cd40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on publishing of: urql-graphql/urql-devtools-exchange#1
Removes 60gzipped bytes