Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic_autonomy unit test #2458

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

adev4a
Copy link
Contributor

@adev4a adev4a commented Nov 7, 2024

PR Details

Fixes an issue in basic_autonomy which causes yield plans to not be checked correctly.
Also fixes unit tests failing because of this invalid check.

Description

Related GitHub Issue

Related Jira Key

https://usdot-carma.atlassian.net/browse/CAR-6009

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adev4a adev4a requested a review from MishkaMN November 7, 2024 04:15
Copy link

sonarcloud bot commented Nov 7, 2024

@adev4a adev4a changed the title fix is_valid_yield and uncomment unit test Fix basic_autonomy unit test Nov 7, 2024
Copy link
Contributor

@MishkaMN MishkaMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MishkaMN MishkaMN merged commit f1df524 into develop Nov 7, 2024
4 checks passed
@MishkaMN MishkaMN deleted the car-6009-fix-basic-autonomy-unit-test branch November 7, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants