-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parity-wasm dependency from contract-build crate #1594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested this against some standard contracts to check that the sizes are the same (or better!)? Would be good to run the contract size check against the integration-tests
.
Also I'd like to see this wasm post-processing refactored to a separate module, this lib.rs
file is big enough already!
crates/build/src/lib.rs
Outdated
let mut output = Vec::new(); | ||
post_process_module( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe post_process_module
could return an allocated Vec<u8>
since it looks like every usage just passes a new buffer instance.
|
Summary
Closes #1141
ink
orpallet-contracts
?Replace
parity-wasm
usage for post processing withwasmparser
andwasm-encoder
Description
Remove
parity-wasm
fromcontract-build
crateImplement the
WASM
post-processing logic withwasmparser
andwasm-encoder
cratesChecklist before requesting a review
CHANGELOG.md